Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonrpc: disable batches and unlimit response sizes #21013

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Jan 30, 2025

When we updated the jsonrpsee dependency a few configuration changes were made unintentially. Specifically batches were re-enabled and response bodies were limited to 10MB. This patch reverts both these semantic changes to the service by disabling batches and removing the cap on response sizes.

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

When we updated the `jsonrpsee` dependency a few configuration changes
were made unintentially. Specifically batches were re-enabled and
response bodies were limited to 10MB. This patch reverts both these
semantic changes to the service by disabling batches and removing the
cap on response sizes.
@bmwill bmwill requested review from johnjmartin and ebmifa January 30, 2025 16:49
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 4:50pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 4:50pm

@bmwill bmwill temporarily deployed to sui-typescript-aws-kms-test-env January 30, 2025 16:49 — with GitHub Actions Inactive
@bmwill bmwill enabled auto-merge (rebase) January 30, 2025 16:50
@bmwill bmwill merged commit 2979d90 into MystenLabs:main Jan 30, 2025
42 checks passed
@bmwill bmwill deleted the jsonrpsee-fix branch January 30, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants